d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kern_cpu: When adding abs frequency allow for unordered insertion

Browse Source 
Keep the list ordered as some code assume that it is but allow for
unordered cf_settings sets.
This commit is contained in:
Emmanuel Vadot 2018-07-19 11:28:14 +00:00
parent 6185fb0f81
commit 326867616f
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/kern/kern_cpu.c
View File

@ -680,7 +680,7 @@ cpufreq_insert_abs(struct cpufreq_softc *sc, struct cf_setting *sets,
{
struct cf_level_lst *list;
struct cf_level *level, *search;
int i;
int i, inserted;
CF_MTX_ASSERT(&sc->lock);
@ -693,6 +693,7 @@ cpufreq_insert_abs(struct cpufreq_softc *sc, struct cf_setting *sets,
level->total_set = sets[i];
level->total_set.dev = NULL;
sc->all_count++;
inserted = 0;
if (TAILQ_EMPTY(list)) {
CF_DEBUG("adding abs setting %d at head\n",
@ -701,15 +702,26 @@ cpufreq_insert_abs(struct cpufreq_softc *sc, struct cf_setting *sets,
continue;
}
TAILQ_FOREACH_REVERSE(search, list, cf_level_lst, link) {
TAILQ_FOREACH_REVERSE(search, list, cf_level_lst, link)
if (sets[i].freq <= search->total_set.freq) {
CF_DEBUG("adding abs setting %d after %d\n",
sets[i].freq, search->total_set.freq);
TAILQ_INSERT_AFTER(list, search, level, link);
inserted = 1;
break;
}
if (inserted == 0) {
TAILQ_FOREACH(search, list, link)
if (sets[i].freq >= search->total_set.freq) {
CF_DEBUG("adding abs setting %d before %d\n",
sets[i].freq, search->total_set.freq);
TAILQ_INSERT_BEFORE(search, level, link);
break;
}
}
}
return (0);
}