d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pidfile test: guarantee nul termination of the read pid string

Browse Source 
PR:	258701
Based on the submission by:	sigsys@gmail.com
MFC after:	1 week
This commit is contained in:
Konstantin Belousov 2021-09-24 06:12:20 +03:00
parent d7cf1b262f
commit 364790beaf
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/libutil/tests/pidfile_test.c
View File

@ -286,7 +286,8 @@ test_pidfile_relative(void)
fd = open(path, O_RDONLY); fd = open(path, O_RDONLY);
if (fd < 0) if (fd < 0)
return (strerror(errno)); return (strerror(errno));
if (read(fd, pid, sizeof(pid)) < 0) memset(pid, 0, sizeof(pid));
if (read(fd, pid, sizeof(pid) - 1) < 0)
return (strerror(errno)); return (strerror(errno));
if (atoi(pid) != getpid()) if (atoi(pid) != getpid())
return ("pid mismatch"); return ("pid mismatch");