d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

unlink_nhgrp: Remove write-only variable.

Browse Source 
Possibly one could assert that ret should always be 0 here (that is,
that there was always an index found in the bitmask).  That should be
true since a bitmask index is allocated before the nhgrp is inserted
in the ctl->gr_head list in link_nhgrp.
This commit is contained in:
John Baldwin 2022-04-06 16:45:27 -07:00
parent 7650d4b67e
commit 371c917b0b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/net/route/nhgrp.c
View File

@ -183,7 +183,7 @@ struct nhgrp_priv *
unlink_nhgrp(struct nh_control *ctl, struct nhgrp_priv *key) unlink_nhgrp(struct nh_control *ctl, struct nhgrp_priv *key)
{ {
struct nhgrp_priv *nhg_priv_ret; struct nhgrp_priv *nhg_priv_ret;
int ret, idx; int idx;
NHOPS_WLOCK(ctl); NHOPS_WLOCK(ctl);
@ -196,7 +196,7 @@ unlink_nhgrp(struct nh_control *ctl, struct nhgrp_priv *key)
} }
idx = nhg_priv_ret->nhg_idx; idx = nhg_priv_ret->nhg_idx;
ret = bitmask_free_idx(&ctl->nh_idx_head, idx); bitmask_free_idx(&ctl->nh_idx_head, idx);
nhg_priv_ret->nhg_idx = 0; nhg_priv_ret->nhg_idx = 0;
nhg_priv_ret->nh_control = NULL; nhg_priv_ret->nh_control = NULL;