d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce MIDI input buffer size to one USB packet, hence some USB devices don't

Browse Source 
properly short terminate their transfers. This fixes a problem where input
appears several seconds late.

Reported by:	Alexander Yerenkow
Submitted by:	Hans Petter Selasky
This commit is contained in:
Andrew Thompson 2010-06-22 21:13:36 +00:00
parent 33ba3721c9
commit 3851442c61
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/dev/sound/usb/uaudio.c
View File

@ -507,8 +507,8 @@ static const struct usb_config
.type = UE_BULK, .type = UE_BULK,
.endpoint = UE_ADDR_ANY, .endpoint = UE_ADDR_ANY,
.direction = UE_DIR_IN, .direction = UE_DIR_IN,
.bufsize = UMIDI_BULK_SIZE, .bufsize = 4, /* bytes */
.flags = {.pipe_bof = 1,.short_xfer_ok = 1,}, .flags = {.pipe_bof = 1,.short_xfer_ok = 1,.proxy_buffer = 1,},
.callback = &umidi_bulk_read_callback, .callback = &umidi_bulk_read_callback,
}, },
@ -3366,10 +3366,6 @@ umidi_bulk_read_callback(struct usb_xfer *xfer, usb_error_t error)
DPRINTF("actlen=%d bytes\n", actlen); DPRINTF("actlen=%d bytes\n", actlen);
if (actlen == 0) {
/* should not happen */
goto tr_error;
}
pos = 0; pos = 0;
pc = usbd_xfer_get_frame(xfer, 0); pc = usbd_xfer_get_frame(xfer, 0);
@ -3404,8 +3400,6 @@ umidi_bulk_read_callback(struct usb_xfer *xfer, usb_error_t error)
return; return;
default: default:
tr_error:
DPRINTF("error=%s\n", usbd_errstr(error)); DPRINTF("error=%s\n", usbd_errstr(error));
if (error != USB_ERR_CANCELLED) { if (error != USB_ERR_CANCELLED) {