From 3e4aa9c629af0e5bd44fffc93cb7a2fc4230e988 Mon Sep 17 00:00:00 2001 From: John Baldwin Date: Thu, 7 Apr 2022 17:01:28 -0700 Subject: [PATCH] pcm atiixp: Remove dead variable. The Linux driver clears ATI_REG_CMD_AC_RESET and sets ATI_REG_CMD_POWERDOWN, so writing the calculated value that sets both would seem to be wrong. This could be updated to match Linux's behavior, but instead I've just left it as-is. --- sys/dev/sound/pci/atiixp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/sound/pci/atiixp.c b/sys/dev/sound/pci/atiixp.c index 21e8350b691e..ff676b97ebed 100644 --- a/sys/dev/sound/pci/atiixp.c +++ b/sys/dev/sound/pci/atiixp.c @@ -1333,7 +1333,6 @@ static int atiixp_pci_suspend(device_t dev) { struct atiixp_info *sc = pcm_getdevinfo(dev); - uint32_t value; /* quickly disable interrupts and save channels active state */ atiixp_lock(sc); @@ -1352,8 +1351,6 @@ atiixp_pci_suspend(device_t dev) /* power down aclink and pci bus */ atiixp_lock(sc); - value = atiixp_rd(sc, ATI_REG_CMD); - value |= ATI_REG_CMD_POWERDOWN | ATI_REG_CMD_AC_RESET; atiixp_wr(sc, ATI_REG_CMD, ATI_REG_CMD_POWERDOWN); atiixp_unlock(sc);