d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pcm atiixp: Remove dead variable.

Browse Source 
The Linux driver clears ATI_REG_CMD_AC_RESET and sets
ATI_REG_CMD_POWERDOWN, so writing the calculated value that sets both
would seem to be wrong.  This could be updated to match Linux's
behavior, but instead I've just left it as-is.
This commit is contained in:
John Baldwin 2022-04-07 17:01:28 -07:00
parent 771e4a8613
commit 3e4aa9c629
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/dev/sound/pci/atiixp.c
View File

@ -1333,7 +1333,6 @@ static int
atiixp_pci_suspend(device_t dev) atiixp_pci_suspend(device_t dev)
{ {
struct atiixp_info *sc = pcm_getdevinfo(dev); struct atiixp_info *sc = pcm_getdevinfo(dev);
uint32_t value;
/* quickly disable interrupts and save channels active state */ /* quickly disable interrupts and save channels active state */
atiixp_lock(sc); atiixp_lock(sc);
@ -1352,8 +1351,6 @@ atiixp_pci_suspend(device_t dev)
/* power down aclink and pci bus */ /* power down aclink and pci bus */
atiixp_lock(sc); atiixp_lock(sc);
value = atiixp_rd(sc, ATI_REG_CMD);
value |= ATI_REG_CMD_POWERDOWN | ATI_REG_CMD_AC_RESET;
atiixp_wr(sc, ATI_REG_CMD, ATI_REG_CMD_POWERDOWN); atiixp_wr(sc, ATI_REG_CMD, ATI_REG_CMD_POWERDOWN);
atiixp_unlock(sc); atiixp_unlock(sc);