From 47e600b575adaf9cee2c00f865eb1af458af9676 Mon Sep 17 00:00:00 2001
From: Bruce Evans <bde@FreeBSD.org>
Date: Thu, 4 Mar 2004 11:20:02 +0000
Subject: [PATCH] Don't manually optimize for 20 year old compilers by casting
to u_int to get a free check for negative ints. Rev.1.35 got my request to
remove the cast mostly backwards.
---
sys/sys/filedesc.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sys/sys/filedesc.h b/sys/sys/filedesc.h
index 512e0c078a64..4ee039994941 100644
--- a/sys/sys/filedesc.h
+++ b/sys/sys/filedesc.h
@@ -163,8 +163,7 @@ static __inline struct file *
fget_locked(struct filedesc *fdp, int fd)
{
- /* u_int cast checks for negative descriptors. */
- return ((u_int)fd >= (u_int)fdp->fd_nfiles ? NULL : fdp->fd_ofiles[fd]);
+ return (fd < 0 || fd >= fdp->fd_nfiles ? NULL : fdp->fd_ofiles[fd]);
}
extern struct mtx fdesc_mtx;