d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Intel PATA UDMA timings setting, affecting write performance.

Browse Source 
Binary divider value 10 specified in datasheet is not a hex 0x10.
UDMA2 should be 33/2 instead of 66/4, which is documented as reverved,
UDMA4 should be 66/2 instead of 66/4, which is definitely wrong.
This commit is contained in:
Alexander Motin 2009-11-22 11:17:31 +00:00
parent 72e2ce370d
commit 48a21eb99c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/ata/chipsets/ata-intel.c
View File

@ -319,7 +319,7 @@ ata_intel_new_setmode(device_t dev, int mode)
ata_mode2str(mode), ctlr->chip->text);
if (!error) {
if (mode >= ATA_UDMA0) {
u_int8_t utimings[] = { 0x00, 0x01, 0x10, 0x01, 0x10, 0x01, 0x10 };
u_int8_t utimings[] = { 0x00, 0x01, 0x02, 0x01, 0x02, 0x01, 0x02 };
pci_write_config(gparent, 0x48, reg48 | (0x0001 << devno), 2);
pci_write_config(gparent, 0x4a,
@ -331,7 +331,7 @@ ata_intel_new_setmode(device_t dev, int mode)
pci_write_config(gparent, 0x4a, (reg4a & ~(0x3 << (devno << 2))),2);
}
reg54 |= 0x0400;
if (mode >= ATA_UDMA2)
if (mode >= ATA_UDMA3)
reg54 |= (0x1 << devno);
else
reg54 &= ~(0x1 << devno);