d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

elftoolchain nm(1): Initialize allocated memory before use

Browse Source 
In out of memory scenarios (where one of these allocations failed but
other(s) did not), nm(1) could reference the uninitialized value of these
allocations (undefined behavior).

Always initialize any successful allocations as the most expedient
resolution of the issue.  However, I would encourage upstream elftoolchain
contributors to clean up the error path to just abort immediately, rather
than proceeding sloppily when one allocation fails.

Reported by:	Coverity
Sponsored by:	Dell EMC Isilon
This commit is contained in:
Conrad Meyer 2018-03-16 22:25:33 +00:00
parent 28e7752907
commit 48fc14c0aa
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
contrib/elftoolchain/nm/nm.c
View File

@ -1310,14 +1310,17 @@ read_elf(Elf *elf, const char *filename, Elf_Kind kind)
line_info = malloc(sizeof(struct line_info_head));
func_info = malloc(sizeof(struct func_info_head));
var_info = malloc(sizeof(struct var_info_head));
if (line_info != NULL)
SLIST_INIT(line_info);
if (func_info != NULL)
SLIST_INIT(func_info);
if (var_info != NULL)
SLIST_INIT(var_info);
if (line_info == NULL || func_info == NULL || var_info == NULL) {
warn("malloc");
(void) dwarf_finish(dbg, &de);
goto process_sym;
}
SLIST_INIT(line_info);
SLIST_INIT(func_info);
SLIST_INIT(var_info);
while ((ret = dwarf_next_cu_header(dbg, NULL, NULL, NULL, NULL, NULL,
&de)) == DW_DLV_OK) {