d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hyperv/hn: Nuke the unused TX taskqueue CPU binding tunable.

Browse Source 
It was an experimental tunable, and is now deemed to be road blocker
for further changes.  Time to retire it.

MFC after:	1 week
Sponsored by:	Microsoft
Differential Revision:	https://reviews.freebsd.org/D8654
This commit is contained in:
Sepherosa Ziehau 2016-11-30 05:11:59 +00:00
parent a8c4b5ced8
commit 52d8123421
1 changed files with 3 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
sys/dev/hyperv/netvsc/if_hn.c
View File

@ -424,11 +424,6 @@ static int hn_use_txdesc_bufring = 1;
SYSCTL_INT(_hw_hn, OID_AUTO, use_txdesc_bufring, CTLFLAG_RD,
&hn_use_txdesc_bufring, 0, "Use buf_ring for TX descriptors");
/* Bind TX taskqueue to the target CPU */
static int hn_bind_tx_taskq = -1;
SYSCTL_INT(_hw_hn, OID_AUTO, bind_tx_taskq, CTLFLAG_RDTUN,
&hn_bind_tx_taskq, 0, "Bind TX taskqueue to the specified cpu");
#ifdef HN_IFSTART_SUPPORT
/* Use ifnet.if_start instead of ifnet.if_transmit */
static int hn_use_if_start = 0;
@ -906,20 +901,8 @@ hn_attach(device_t dev)
if (hn_tx_taskq == NULL) {
sc->hn_tx_taskq = taskqueue_create("hn_tx", M_WAITOK,
taskqueue_thread_enqueue, &sc->hn_tx_taskq);
if (hn_bind_tx_taskq >= 0) {
int cpu = hn_bind_tx_taskq;
cpuset_t cpu_set;
if (cpu > mp_ncpus - 1)
cpu = mp_ncpus - 1;
CPU_SETOF(cpu, &cpu_set);
taskqueue_start_threads_cpuset(&sc->hn_tx_taskq, 1,
PI_NET, &cpu_set, "%s tx",
device_get_nameunit(dev));
} else {
taskqueue_start_threads(&sc->hn_tx_taskq, 1, PI_NET,
"%s tx", device_get_nameunit(dev));
}
taskqueue_start_threads(&sc->hn_tx_taskq, 1, PI_NET, "%s tx",
device_get_nameunit(dev));
} else {
sc->hn_tx_taskq = hn_tx_taskq;
}
@ -5360,18 +5343,7 @@ hn_tx_taskq_create(void *arg __unused)
hn_tx_taskq = taskqueue_create("hn_tx", M_WAITOK,
taskqueue_thread_enqueue, &hn_tx_taskq);
if (hn_bind_tx_taskq >= 0) {
int cpu = hn_bind_tx_taskq;
cpuset_t cpu_set;
if (cpu > mp_ncpus - 1)
cpu = mp_ncpus - 1;
CPU_SETOF(cpu, &cpu_set);
taskqueue_start_threads_cpuset(&hn_tx_taskq, 1, PI_NET,
&cpu_set, "hn tx");
} else {
taskqueue_start_threads(&hn_tx_taskq, 1, PI_NET, "hn tx");
}
taskqueue_start_threads(&hn_tx_taskq, 1, PI_NET, "hn tx");
}
SYSINIT(hn_txtq_create, SI_SUB_DRIVERS, SI_ORDER_SECOND,
hn_tx_taskq_create, NULL);