d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

With the magic sequence checks removed this class is downright dangerous

Browse Source 
to have in your kernel since it indiscriminately attaches to anything
it is offered with a range of bogus partitions.

Stop this from happening by rejecting any label with negative numbers in
it.
This commit is contained in:
Poul-Henning Kamp 2003-04-09 13:08:36 +00:00
parent a067f0991b
commit 551e52efb8
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
sys/geom/geom_pc98.c
View File

@ -114,7 +114,7 @@ g_pc98_modify(struct g_geom *gp, struct g_pc98_softc *ms, u_char *sec)
#if 0
/*
* XXX: Some sources indicate this is a magic sequence, but appearantly
* XXX: it is not universal. Documentation would be wonderfule to have.
* XXX: it is not universal. Documentation would be wonderful to have.
*/
if (sec[4] != 'I' || sec[5] != 'P' || sec[6] != 'L' || sec[7] != '1')
return (EBUSY);
@ -142,7 +142,10 @@ g_pc98_modify(struct g_geom *gp, struct g_pc98_softc *ms, u_char *sec)
printf("PC98 Slice %d on %s:\n", i + 1, gp->name);
g_pc98_print(i, dp + i);
}
error = g_slice_config(gp, i, G_SLICE_CONFIG_CHECK,
if (s[i] < 0 || l[i] < 0)
error = EBUSY;
else
error = g_slice_config(gp, i, G_SLICE_CONFIG_CHECK,
s[i], l[i], ms->sectorsize,
"%ss%d", gp->name, i + 1);
if (error)
@ -311,14 +314,16 @@ g_pc98_taste(struct g_class *mp, struct g_provider *pp, int flags)
error = g_getattr("GEOM::fwsectors", cp, &fwsectors);
if (error || fwsectors == 0) {
fwsectors = 17;
printf("g_pc98_taste: error %d guessing %d sectors\n",
error, fwsectors);
if (bootverbose)
printf("g_pc98_taste: guessing %d sectors\n",
fwsectors);
}
error = g_getattr("GEOM::fwheads", cp, &fwheads);
if (error || fwheads == 0) {
fwheads = 8;
printf("g_pc98_taste: error %d guessing %d heads\n",
error, fwheads);
if (bootverbose)
printf("g_pc98_taste: guessing %d heads\n",
fwheads);
}
sectorsize = cp->provider->sectorsize;
if (sectorsize < 512)