d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

For architectures not using direct map , and requiring real KVA page for

Browse Source 
sf buf allocation, use wakeup() instead of wakeup_one() to notify sf
buffer waiters about free buffer.

sf_buf_alloc() calls msleep(PCATCH) when SFB_CATCH flag was given,
and for simultaneous wakeup and signal delivery, msleep() returns
EINTR/ERESTART despite the thread was selected for wakeup_one(). As
result, we loose a wakeup, and some other waiter will not be woken up.

Reported and tested by:	az
Reviewed by:	alc, jhb
MFC after:	1 week
This commit is contained in:
Konstantin Belousov 2011-01-18 21:57:02 +00:00
parent 14be64618e
commit 55aabb7fd1
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/arm/arm/vm_machdep.c
View File

@ -175,7 +175,7 @@ sf_buf_free(struct sf_buf *sf)
sf->m = NULL;
LIST_REMOVE(sf, list_entry);
if (sf_buf_alloc_want > 0)
wakeup_one(&sf_buf_freelist);
wakeup(&sf_buf_freelist);
}
mtx_unlock(&sf_buf_lock);
#endif

2
sys/i386/i386/vm_machdep.c
View File

@ -916,7 +916,7 @@ sf_buf_free(struct sf_buf *sf)
LIST_REMOVE(sf, list_entry);
#endif
if (sf_buf_alloc_want > 0)
wakeup_one(&sf_buf_freelist);
wakeup(&sf_buf_freelist);
}
mtx_unlock(&sf_buf_lock);
}

2
sys/mips/mips/vm_machdep.c
View File

@ -528,7 +528,7 @@ sf_buf_free(struct sf_buf *sf)
SLIST_INSERT_HEAD(&sf_freelist.sf_head, sf, free_list);
nsfbufsused--;
if (sf_buf_alloc_want > 0)
wakeup_one(&sf_freelist);
wakeup(&sf_freelist);
mtx_unlock(&sf_freelist.sf_lock);
}

2
sys/powerpc/aim/vm_machdep.c
View File

@ -347,7 +347,7 @@ sf_buf_free(struct sf_buf *sf)
nsfbufsused--;
if (sf_buf_alloc_want > 0)
wakeup_one(&sf_buf_freelist);
wakeup(&sf_buf_freelist);
}
mtx_unlock(&sf_buf_lock);
}

2
sys/powerpc/booke/vm_machdep.c
View File

@ -346,7 +346,7 @@ sf_buf_free(struct sf_buf *sf)
nsfbufsused--;
if (sf_buf_alloc_want > 0)
wakeup_one(&sf_buf_freelist);
wakeup(&sf_buf_freelist);
}
mtx_unlock(&sf_buf_lock);
}

2
sys/sparc64/sparc64/vm_machdep.c
View File

@ -483,7 +483,7 @@ sf_buf_free(struct sf_buf *sf)
SLIST_INSERT_HEAD(&sf_freelist.sf_head, sf, free_list);
nsfbufsused--;
if (sf_buf_alloc_want > 0)
wakeup_one(&sf_freelist);
wakeup(&sf_freelist);
mtx_unlock(&sf_freelist.sf_lock);
}