d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sesutil: fix "fault all" with zoned jbods

Browse Source 
Some SAS JBODs support zoning.  This feature allows individual SAS
targets to be accessible by only some initiator ports.  One application
would be connecting two servers to the same JBOD, but they wouldn't be
able to see each other's disks.

A zoned JBOD should also prohibit initiators from accessing SES elements
corresponding to inaccessible SAS targets.  It reports that by setting
the element's status code to 0x8 (No Access Allowed).

The bug is that when doing "sesutil (fault|locate) all ...", sesutil
will attempt a ENCIOC_SETELMSTAT ioctl for every single element, even
the inaccessible ones.  The enclosure will reject the command, the
kernel will return EINVAL, and sesutil will exit.

The solution is to check the element's status, and skip trying to set it
if the status is 0x8.  But if the user actually supplied a ses ID, then
assume that he knows what he's doing and try to set it anyway.

PR:		270093
MFC after:	1 week
Sponsored by:	Axcient
Reviewed by:	mav, trasz
Differential Revision: https://reviews.freebsd.org/D39017
This commit is contained in:
Alan Somers 2023-03-10 10:47:08 -07:00
parent b894193501
commit 57dc6f5e20
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
usr.sbin/sesutil/sesutil.c
View File

@ -281,6 +281,16 @@ sesled(int argc, char **argv, bool setfault)
char devnames[devnames_size];
if (all) {
encioc_elm_status_t es;
memset(&es, 0, sizeof(es));
es.elm_idx = objp[j].elm_idx;
if (ioctl(fd, ENCIOC_GETELMSTAT, &es) < 0) {
close(fd);
xo_err(EXIT_FAILURE,
"ENCIOC_GETELMSTAT");
}
if ((es.cstat[0] & 0xf) == SES_OBJSTAT_NOACCESS)
continue;
do_led(fd, objp[j].elm_idx, objp[j].elm_type,
onoff, setfault);
continue;