From 582a77606f9ce3c852fb6228b96abc1428d069f5 Mon Sep 17 00:00:00 2001
From: Bruce Evans <bde@FreeBSD.org>
Date: Wed, 24 May 2000 12:57:52 +0000
Subject: [PATCH] Fixed some style bugs (mainly convoluted logic for blackhole
 processing).

---
 sys/netinet/udp_usrreq.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c
index 2bb10e6b5569..3eac9ee1602d 100644
--- a/sys/netinet/udp_usrreq.c
+++ b/sys/netinet/udp_usrreq.c
@@ -350,14 +350,11 @@ udp_input(m, off, proto)
 			goto bad;
 		}
 		*ip = save_ip;
-
 		if (badport_bandlim(0) < 0)
 			goto bad;
-
-		if (!blackhole)
-			icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_PORT, 0, 0);
-		else
+		if (blackhole)
 			goto bad;
+		icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_PORT, 0, 0);
 		return;
 	}
 #ifdef IPSEC
@@ -905,4 +902,3 @@ struct pr_usrreqs udp_usrreqs = {
 	pru_rcvoob_notsupp, udp_send, pru_sense_null, udp_shutdown,
 	in_setsockaddr, sosend, soreceive, sopoll
 };
-