d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arm: implement kdb watchpoint functions

Browse Source 
Implement wrappers around the existing debug_monitor interface, to be
consumed by MI kernel debugger code.

For now, the various db_printf() calls in this code remain. In the
future, they could be converted to printf() or removed altogether, to
properly decouple the DDB and GDB options.

Reviewed by:	jhb, kib, markj
MFC after:	3 weeks
Sponsored by:	NetApp, Inc.
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D29155
This commit is contained in:
Mitchell Horne 2021-03-03 20:14:42 -04:00
parent 3ef68bc62c
commit 5a2933d0bf
2 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
sys/arm/arm/debug_monitor.c
View File

@ -326,6 +326,35 @@ kdb_cpu_clear_singlestep(void)
}
}
int
kdb_cpu_set_watchpoint(vm_offset_t addr, size_t size, int access)
{
enum dbg_access_t dbg_access;
switch (access) {
case KDB_DBG_ACCESS_R:
dbg_access = HW_WATCHPOINT_R;
break;
case KDB_DBG_ACCESS_W:
dbg_access = HW_WATCHPOINT_W;
break;
case KDB_DBG_ACCESS_RW:
dbg_access = HW_WATCHPOINT_RW;
break;
default:
return (EINVAL);
}
return (dbg_setup_watchpoint(addr, size, (enum dbg_access_t)access));
}
int
kdb_cpu_clr_watchpoint(vm_offset_t addr, size_t size)
{
return (dbg_remove_watchpoint(addr, size));
}
int
dbg_setup_watchpoint(db_expr_t addr, db_expr_t size, enum dbg_access_t access)
{
@ -624,7 +653,7 @@ dbg_setup_xpoint(struct dbg_wb_conf *conf)
if (i == ~0U) {
db_printf("Can not find slot for %s, max %d slots supported\n",
typestr, dbg_watchpoint_num);
return (ENXIO);
return (EBUSY);
}
}
@ -645,7 +674,8 @@ dbg_setup_xpoint(struct dbg_wb_conf *conf)
cr_size = DBG_WB_CTRL_LEN_8;
break;
default:
db_printf("Unsupported address size for %s\n", typestr);
db_printf("Unsupported address size for %s: %zu\n", typestr,
conf->size);
return (EINVAL);
}
@ -667,7 +697,8 @@ dbg_setup_xpoint(struct dbg_wb_conf *conf)
cr_access = DBG_WB_CTRL_LOAD | DBG_WB_CTRL_STORE;
break;
default:
db_printf("Unsupported exception level for %s\n", typestr);
db_printf("Unsupported access type for %s: %d\n",
typestr, conf->access);
return (EINVAL);
}

2
sys/arm/include/kdb.h
View File

@ -41,6 +41,8 @@
extern void kdb_cpu_clear_singlestep(void);
extern void kdb_cpu_set_singlestep(void);
boolean_t kdb_cpu_pc_is_singlestep(db_addr_t);
int kdb_cpu_set_watchpoint(vm_offset_t addr, size_t size, int access);
int kdb_cpu_clr_watchpoint(vm_offset_t addr, size_t size);
static __inline void
kdb_cpu_sync_icache(unsigned char *addr, size_t size)