d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve debuggability of VOP_* locking assertions

Browse Source 
Include the phase and argument field to make it easier to determine
at a glance where the failure originated.

Reviewed by:	kib, markj
Differential Revision: https://reviews.freebsd.org/D38091
This commit is contained in:
Jason A. Harmening 2023-01-16 14:07:19 -06:00
parent 846e4a206f
commit 5a4a83fd0e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/tools/vnode_if.awk
View File

@ -73,14 +73,14 @@ function add_debug_code(name, arg, pos, ind)
else
star = "";
if (lockdata[name, arg, pos] && (lockdata[name, arg, pos] != "-")) {
printc(ind"ASSERT_VI_UNLOCKED("star"a->a_"arg", \""uname"\");");
printc(ind"ASSERT_VI_UNLOCKED("star"a->a_"arg", \""uname" "pos" ("arg")\");");
# Add assertions for locking
if (lockdata[name, arg, pos] == "L")
printc(ind"ASSERT_VOP_LOCKED(" star "a->a_"arg", \""uname"\");");
printc(ind"ASSERT_VOP_LOCKED(" star "a->a_"arg", \""uname" "pos" ("arg")\");");
else if (lockdata[name, arg, pos] == "U")
printc(ind"ASSERT_VOP_UNLOCKED(" star "a->a_"arg", \""uname"\");");
printc(ind"ASSERT_VOP_UNLOCKED(" star "a->a_"arg", \""uname" "pos" ("arg")\");");
else if (lockdata[name, arg, pos] == "E")
printc(ind"ASSERT_VOP_ELOCKED(" star "a->a_"arg", \""uname"\");");
printc(ind"ASSERT_VOP_ELOCKED(" star "a->a_"arg", \""uname" "pos" ("arg")\");");
else if (0) {
# XXX More checks!
}