d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fxp: Remove unneeded Giant from bus_dma_tag_create().

Browse Source 
All bus_dmamap_load() calls here use BUS_DMA_NOWAIT.

MFC after:	2 weeks
This commit is contained in:
Alexander Motin 2021-12-09 20:09:48 -05:00
parent de291c5d10
commit 5ae7518b7b
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sys/dev/fxp/if_fxp.c
View File

@ -667,8 +667,7 @@ fxp_attach(device_t dev)
error = bus_dma_tag_create(bus_get_dma_tag(dev), 2, 0, error = bus_dma_tag_create(bus_get_dma_tag(dev), 2, 0,
BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
sc->maxsegsize * sc->maxtxseg + sizeof(struct ether_vlan_header), sc->maxsegsize * sc->maxtxseg + sizeof(struct ether_vlan_header),
sc->maxtxseg, sc->maxsegsize, 0, sc->maxtxseg, sc->maxsegsize, 0, NULL, NULL, &sc->fxp_txmtag);
busdma_lock_mutex, &Giant, &sc->fxp_txmtag);
if (error) { if (error) {
device_printf(dev, "could not create TX DMA tag\n"); device_printf(dev, "could not create TX DMA tag\n");
goto fail; goto fail;
@ -676,8 +675,7 @@ fxp_attach(device_t dev)
error = bus_dma_tag_create(bus_get_dma_tag(dev), 2, 0, error = bus_dma_tag_create(bus_get_dma_tag(dev), 2, 0,
BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
MCLBYTES, 1, MCLBYTES, 0, MCLBYTES, 1, MCLBYTES, 0, NULL, NULL, &sc->fxp_rxmtag);
busdma_lock_mutex, &Giant, &sc->fxp_rxmtag);
if (error) { if (error) {
device_printf(dev, "could not create RX DMA tag\n"); device_printf(dev, "could not create RX DMA tag\n");
goto fail; goto fail;
@ -686,7 +684,7 @@ fxp_attach(device_t dev)
error = bus_dma_tag_create(bus_get_dma_tag(dev), 4, 0, error = bus_dma_tag_create(bus_get_dma_tag(dev), 4, 0,
BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
sizeof(struct fxp_stats), 1, sizeof(struct fxp_stats), 0, sizeof(struct fxp_stats), 1, sizeof(struct fxp_stats), 0,
busdma_lock_mutex, &Giant, &sc->fxp_stag); NULL, NULL, &sc->fxp_stag);
if (error) { if (error) {
device_printf(dev, "could not create stats DMA tag\n"); device_printf(dev, "could not create stats DMA tag\n");
goto fail; goto fail;
@ -708,8 +706,7 @@ fxp_attach(device_t dev)
error = bus_dma_tag_create(bus_get_dma_tag(dev), 4, 0, error = bus_dma_tag_create(bus_get_dma_tag(dev), 4, 0,
BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
FXP_TXCB_SZ, 1, FXP_TXCB_SZ, 0, FXP_TXCB_SZ, 1, FXP_TXCB_SZ, 0, NULL, NULL, &sc->cbl_tag);
busdma_lock_mutex, &Giant, &sc->cbl_tag);
if (error) { if (error) {
device_printf(dev, "could not create TxCB DMA tag\n"); device_printf(dev, "could not create TxCB DMA tag\n");
goto fail; goto fail;
@ -733,7 +730,7 @@ fxp_attach(device_t dev)
error = bus_dma_tag_create(bus_get_dma_tag(dev), 4, 0, error = bus_dma_tag_create(bus_get_dma_tag(dev), 4, 0,
BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
sizeof(struct fxp_cb_mcs), 1, sizeof(struct fxp_cb_mcs), 0, sizeof(struct fxp_cb_mcs), 1, sizeof(struct fxp_cb_mcs), 0,
busdma_lock_mutex, &Giant, &sc->mcs_tag); NULL, NULL, &sc->mcs_tag);
if (error) { if (error) {
device_printf(dev, device_printf(dev,
"could not create multicast setup DMA tag\n"); "could not create multicast setup DMA tag\n");