d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix SIGINFO stack collection to ignore threads with swapped-out stacks.

Browse Source 
We by definition cannot trace the stack of such a thread.  Also remove a
redundant stack_zero() call in the SIGINFO handler, the stack structure
is cleared by the MD stack_capture().

Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Mark Johnston 2019-12-19 19:34:25 +00:00
parent d8d5f03610
commit 5d3bd9e242
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/kern/tty_info.c
View File

@ -338,8 +338,9 @@ tty_info(struct tty *tp)
pctcpu = (sched_pctcpu(td) * 10000 + FSCALE / 2) >> FSHIFT;
#ifdef STACK
if (tty_info_kstacks) {
stack_zero(&stack);
if (TD_IS_SWAPPED(td) || TD_IS_RUNNING(td))
if (TD_IS_SWAPPED(td))
sterr = ENOENT;
else if (TD_IS_RUNNING(td))
sterr = stack_save_td_running(&stack, td);
else {
stack_save_td(&stack, td);