d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MFp4: Calculate the divisor before setting the DLAB bit. This

Browse Source 
prevents that there's a control flow that leaves the DLAB
	bit set.
This commit is contained in:
Marcel Moolenaar 2006-04-23 21:15:07 +00:00
parent b9fcadb97c
commit 63f8efd314
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/uart/uart_dev_ns8250.c
View File

@ -194,11 +194,11 @@ ns8250_param(struct uart_bas *bas, int baudrate, int databits, int stopbits,
/* Set baudrate. */
if (baudrate > 0) {
uart_setreg(bas, REG_LCR, lcr | LCR_DLAB);
uart_barrier(bas);
divisor = ns8250_divisor(bas->rclk, baudrate);
if (divisor == 0)
return (EINVAL);
uart_setreg(bas, REG_LCR, lcr | LCR_DLAB);
uart_barrier(bas);
uart_setdreg(bas, REG_DL, divisor);
uart_barrier(bas);
}