d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In the routines vrele() and vput(), we must lock the vnode and

Browse Source 
call VOP_INACTIVE before placing the vnode back on the free list.
Otherwise there is a race condition on SMP machines between
getnewvnode() locking the vnode to reclaim it and vrele()
locking the vnode to inactivate it. This window of vulnerability
becomes exaggerated in the presence of filesystems that have
been suspended as the inactive routine may need to temporarily
release the lock on the vnode to avoid deadlock with the syncer
process.
This commit is contained in:
Kirk McKusick 2002-02-02 01:49:18 +00:00
parent 602a222d02
commit 64011154e5
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
sys/kern/vfs_subr.c
View File

@ -1727,18 +1727,18 @@ vrele(vp)
if (vp->v_usecount == 1) {
vp->v_usecount--;
/*
* We must call VOP_INACTIVE with the node locked.
* If we are doing a vput, the node is already locked,
* but, in the case of vrele, we must explicitly lock
* the vnode before calling VOP_INACTIVE.
*/
if (vn_lock(vp, LK_EXCLUSIVE | LK_INTERLOCK, td) == 0)
VOP_INACTIVE(vp, td);
if (VSHOULDFREE(vp))
vfree(vp);
else
vlruvp(vp);
/*
* If we are doing a vput, the node is already locked, and we must
* call VOP_INACTIVE with the node locked. So, in the case of
* vrele, we explicitly lock the vnode before calling VOP_INACTIVE.
*/
if (vn_lock(vp, LK_EXCLUSIVE | LK_INTERLOCK, td) == 0) {
VOP_INACTIVE(vp, td);
}
} else {
#ifdef DIAGNOSTIC
@ -1776,17 +1776,17 @@ vput(vp)
if (vp->v_usecount == 1) {
vp->v_usecount--;
/*
* We must call VOP_INACTIVE with the node locked.
* If we are doing a vput, the node is already locked,
* so we just need to release the vnode mutex.
*/
mtx_unlock(&vp->v_interlock);
VOP_INACTIVE(vp, td);
if (VSHOULDFREE(vp))
vfree(vp);
else
vlruvp(vp);
/*
* If we are doing a vput, the node is already locked, and we must
* call VOP_INACTIVE with the node locked. So, in the case of
* vrele, we explicitly lock the vnode before calling VOP_INACTIVE.
*/
mtx_unlock(&vp->v_interlock);
VOP_INACTIVE(vp, td);
} else {
#ifdef DIAGNOSTIC