d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

subr_firmware.c::unloadentry(): remote write-only variable

Browse Source 
The function ignores result returned by linker_release_module().
The FW_UNLOAD flag on the file is cleared, so even on error it would
not be tried again.

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
This commit is contained in:
Konstantin Belousov 2021-10-21 20:40:24 +03:00
parent 993446638c
commit 6776747a0e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/kern/subr_firmware.c
View File

@ -412,7 +412,6 @@ static void
unloadentry(void *unused1, int unused2)
{
struct priv_fw *fp;
int err;
mtx_lock(&firmware_mtx);
restart:
@ -434,7 +433,7 @@ unloadentry(void *unused1, int unused2)
* on unload to actually free the entry.
*/
mtx_unlock(&firmware_mtx);
err = linker_release_module(NULL, NULL, fp->file);
(void)linker_release_module(NULL, NULL, fp->file);
mtx_lock(&firmware_mtx);
/*