d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Be careful not to dereference NULL credentials pointers when doing the

Browse Source 
getattr function.
This commit is contained in:
David Greenman 1995-08-11 07:26:26 +00:00
parent 90fb65d02e
commit 67d7e54eb1
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/fs/procfs/procfs_vnops.c
View File

@ -36,7 +36,7 @@
*
* @(#)procfs_vnops.c 8.6 (Berkeley) 2/7/94
*
* $Id: procfs_vnops.c,v 1.13 1995/05/25 01:35:24 davidg Exp $
* $Id: procfs_vnops.c,v 1.14 1995/05/30 08:07:13 rgrimes Exp $
*/
/*
@ -311,7 +311,10 @@ procfs_getattr(ap)
struct proc *procp;
int error;
/* first check the process still exists */
/*
* First make sure that the process and its credentials
* still exist.
*/
switch (pfs->pfs_type) {
case Proot:
procp = 0;
@ -319,7 +322,8 @@ procfs_getattr(ap)
default:
procp = PFIND(pfs->pfs_pid);
if (procp == 0)
if (procp == 0 || procp->p_cred == NULL ||
procp->p_ucred == NULL)
return (ENOENT);
}

10
sys/miscfs/procfs/procfs_vnops.c
View File

@ -36,7 +36,7 @@
*
* @(#)procfs_vnops.c 8.6 (Berkeley) 2/7/94
*
* $Id: procfs_vnops.c,v 1.13 1995/05/25 01:35:24 davidg Exp $
* $Id: procfs_vnops.c,v 1.14 1995/05/30 08:07:13 rgrimes Exp $
*/
/*
@ -311,7 +311,10 @@ procfs_getattr(ap)
struct proc *procp;
int error;
/* first check the process still exists */
/*
* First make sure that the process and its credentials
* still exist.
*/
switch (pfs->pfs_type) {
case Proot:
procp = 0;
@ -319,7 +322,8 @@ procfs_getattr(ap)
default:
procp = PFIND(pfs->pfs_pid);
if (procp == 0)
if (procp == 0 || procp->p_cred == NULL ||
procp->p_ucred == NULL)
return (ENOENT);
}