d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Using off_t to pass a block size is obvious overkill.

Browse Source 
The size_t type is better suited for that, particularly because
the "blksize" argument is to be passed to malloc() and read().
On 64-bit archs it's more to a style issue, but the good style
of coding in C is also important.
This commit is contained in:
Yaroslav Tykhiy 2004-11-13 13:42:43 +00:00
parent e3765043a8
commit 6e4b0a55f7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libexec/ftpd/ftpd.c
View File

@ -252,7 +252,7 @@ static int guniquefd(char *, char **);
static void lostconn(int);
static void sigquit(int);
static int receive_data(FILE *, FILE *);
static int send_data(FILE *, FILE *, off_t, off_t, int);
static int send_data(FILE *, FILE *, size_t, off_t, int);
static struct passwd *
sgetpwnam(char *);
static char *sgetsave(char *);
@ -2005,7 +2005,7 @@ dataconn(char *name, off_t size, char *mode)
* NB: Form isn't handled.
*/
static int
send_data(FILE *instr, FILE *outstr, off_t blksize, off_t filesize, int isreg)
send_data(FILE *instr, FILE *outstr, size_t blksize, off_t filesize, int isreg)
{
int c, cp, filefd, netfd;
char *buf;