From 6e4b0a55f72e25c58aea64acfcdab0b32721c2d2 Mon Sep 17 00:00:00 2001 From: Yaroslav Tykhiy Date: Sat, 13 Nov 2004 13:42:43 +0000 Subject: [PATCH] Using off_t to pass a block size is obvious overkill. The size_t type is better suited for that, particularly because the "blksize" argument is to be passed to malloc() and read(). On 64-bit archs it's more to a style issue, but the good style of coding in C is also important. --- libexec/ftpd/ftpd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libexec/ftpd/ftpd.c b/libexec/ftpd/ftpd.c index f40bd954506f..8705dc8c278e 100644 --- a/libexec/ftpd/ftpd.c +++ b/libexec/ftpd/ftpd.c @@ -252,7 +252,7 @@ static int guniquefd(char *, char **); static void lostconn(int); static void sigquit(int); static int receive_data(FILE *, FILE *); -static int send_data(FILE *, FILE *, off_t, off_t, int); +static int send_data(FILE *, FILE *, size_t, off_t, int); static struct passwd * sgetpwnam(char *); static char *sgetsave(char *); @@ -2005,7 +2005,7 @@ dataconn(char *name, off_t size, char *mode) * NB: Form isn't handled. */ static int -send_data(FILE *instr, FILE *outstr, off_t blksize, off_t filesize, int isreg) +send_data(FILE *instr, FILE *outstr, size_t blksize, off_t filesize, int isreg) { int c, cp, filefd, netfd; char *buf;