d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bwi: Remove write-only variable

Browse Source 
bbp_atten is write-only: we don't use it later in
bwi_rf_calc_nrssi_slope_11b. However, we may also be able to eliminate
the read of this value from the device. However, The documationation for
this hardware is thing and I can't test this card so I've left the read
of this register in case it's required.

Sponsored by:		Netflix
This commit is contained in:
Warner Losh 2022-04-05 13:07:20 -06:00
parent cbf7b9e6ee
commit 6e5056a903
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/bwi/bwirf.c
View File

@ -1649,7 +1649,7 @@ bwi_rf_calc_nrssi_slope_11b(struct bwi_mac *mac)
struct bwi_phy *phy = &mac->mac_phy;
uint16_t save_rf[SAVE_RF_MAX];
uint16_t save_phy[SAVE_PHY_MAX];
uint16_t ant_div, bbp_atten, chan_ex;
uint16_t ant_div, chan_ex;
int16_t nrssi[2];
int i;
@ -1662,7 +1662,7 @@ bwi_rf_calc_nrssi_slope_11b(struct bwi_mac *mac)
save_phy[i] = PHY_READ(mac, save_phy_regs[i]);
ant_div = CSR_READ_2(sc, BWI_RF_ANTDIV);
bbp_atten = CSR_READ_2(sc, BWI_BBP_ATTEN);
CSR_READ_2(sc, BWI_BBP_ATTEN);
chan_ex = CSR_READ_2(sc, BWI_RF_CHAN_EX);
/*