d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Trim comments about the MP-safety of various bits of the amd64/i386

Browse Source 
system call entry path and i386 IP checksum generation: we now assume
all code is MPSAFE unless explicitly marked otherwise.  Remove XXX
Giant comments along similar lines: the code by the comments either
doesn't need or doesn't want Giant (especially the NMI handler).

MFC after:	3 days
This commit is contained in:
Robert Watson 2009-03-09 13:11:16 +00:00
parent 4e3328b3cf
commit 6f63bf4edf
3 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/amd64/amd64/trap.c
View File

@ -386,7 +386,6 @@ trap(struct trapframe *frame)
#ifdef DEV_ISA
case T_NMI:
/* machine/parity/power fail/"kitchen sink" faults */
/* XXX Giant */
if (isa_nmi(code) == 0) {
#ifdef KDB
/*
@ -530,7 +529,6 @@ trap(struct trapframe *frame)
#ifdef DEV_ISA
case T_NMI:
/* XXX Giant */
/* machine/parity/power fail/"kitchen sink" faults */
if (isa_nmi(code) == 0) {
#ifdef KDB
@ -820,9 +818,6 @@ syscall(struct trapframe *frame)
orig_tf_rflags = frame->tf_rflags;
if (p->p_sysent->sv_prepsyscall) {
/*
* The prep code is MP aware.
*/
(*p->p_sysent->sv_prepsyscall)(frame, (int *)args, &code, &params);
} else {
if (code == SYS_syscall || code == SYS___syscall) {
@ -841,10 +836,6 @@ syscall(struct trapframe *frame)
callp = &p->p_sysent->sv_table[code];
narg = callp->sy_narg;
/*
* copyin and the ktrsyscall()/ktrsysret() code is MP-aware
*/
KASSERT(narg <= sizeof(args) / sizeof(args[0]),
("Too many syscall arguments!"));
error = 0;

3
sys/i386/i386/in_cksum.c
View File

@ -33,9 +33,6 @@
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
/*
* MPsafe: alfred
*/
#include <sys/param.h>
#include <sys/systm.h>
#include <sys/mbuf.h>

10
sys/i386/i386/trap.c
View File

@ -461,7 +461,6 @@ trap(struct trapframe *frame)
goto userout;
#else /* !POWERFAIL_NMI */
/* machine/parity/power fail/"kitchen sink" faults */
/* XXX Giant */
if (isa_nmi(code) == 0) {
#ifdef KDB
/*
@ -658,7 +657,6 @@ trap(struct trapframe *frame)
* in kernel space because that is useful when
* debugging the kernel.
*/
/* XXX Giant */
if (user_dbreg_trap() &&
!(PCPU_GET(curpcb)->pcb_flags & PCB_VM86CALL)) {
/*
@ -692,7 +690,6 @@ trap(struct trapframe *frame)
}
goto out;
#else /* !POWERFAIL_NMI */
/* XXX Giant */
/* machine/parity/power fail/"kitchen sink" faults */
if (isa_nmi(code) == 0) {
#ifdef KDB
@ -999,14 +996,10 @@ syscall(struct trapframe *frame)
orig_tf_eflags = frame->tf_eflags;
if (p->p_sysent->sv_prepsyscall) {
/*
* The prep code is MP aware.
*/
(*p->p_sysent->sv_prepsyscall)(frame, args, &code, &params);
} else {
/*
* Need to check if this is a 32 bit or 64 bit syscall.
* fuword is MP aware.
*/
if (code == SYS_syscall) {
/*
@ -1034,9 +1027,6 @@ syscall(struct trapframe *frame)
narg = callp->sy_narg;
/*
* copyin and the ktrsyscall()/ktrsysret() code is MP-aware
*/
if (params != NULL && narg != 0)
error = copyin(params, (caddr_t)args,
(u_int)(narg * sizeof(int)));