d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed sign extension bugs awoken by changing speed_t to an unsigned

Browse Source 
type.  19200, 1200 and other relatively uninteresting speeds were
broken.

Submitted by:	Rob Mallory <rmallory@qualcomm.com>
This commit is contained in:
Bruce Evans 1998-07-29 18:48:20 +00:00
parent 8a8a13c8f0
commit 7010319f16
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/cy/cy.c
View File

@ -27,7 +27,7 @@
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* $Id: cy.c,v 1.63 1998/06/07 17:10:16 dfr Exp $
* $Id: cy.c,v 1.64 1998/07/15 12:18:12 bde Exp $
*/
#include "opt_compat.h"
@ -2482,7 +2482,9 @@ comspeed(speed, prescaler_io)
if (divider > 255)
divider = 255;
actual = CY_CLOCK/prescaler/divider;
error = ((actual - speed) * 2000 / speed + 1) / 2; /* percentage */
/* 10 times error in percent: */
error = ((actual - (long)speed) * 2000 / (long)speed + 1) / 2;
/* 3.0% max error tolerance */
if (error < -30 || error > 30)

6
sys/dev/cy/cy_isa.c
View File

@ -27,7 +27,7 @@
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* $Id: cy.c,v 1.63 1998/06/07 17:10:16 dfr Exp $
* $Id: cy.c,v 1.64 1998/07/15 12:18:12 bde Exp $
*/
#include "opt_compat.h"
@ -2482,7 +2482,9 @@ comspeed(speed, prescaler_io)
if (divider > 255)
divider = 255;
actual = CY_CLOCK/prescaler/divider;
error = ((actual - speed) * 2000 / speed + 1) / 2; /* percentage */
/* 10 times error in percent: */
error = ((actual - (long)speed) * 2000 / (long)speed + 1) / 2;
/* 3.0% max error tolerance */
if (error < -30 || error > 30)

6
sys/i386/isa/cy.c
View File

@ -27,7 +27,7 @@
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* $Id: cy.c,v 1.63 1998/06/07 17:10:16 dfr Exp $
* $Id: cy.c,v 1.64 1998/07/15 12:18:12 bde Exp $
*/
#include "opt_compat.h"
@ -2482,7 +2482,9 @@ comspeed(speed, prescaler_io)
if (divider > 255)
divider = 255;
actual = CY_CLOCK/prescaler/divider;
error = ((actual - speed) * 2000 / speed + 1) / 2; /* percentage */
/* 10 times error in percent: */
error = ((actual - (long)speed) * 2000 / (long)speed + 1) / 2;
/* 3.0% max error tolerance */
if (error < -30 || error > 30)