d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bhyve: Tidy vCPU pthread startup.

Browse Source 
Set the thread affinity in fbsdrun_start_thread next to where the
thread name is set.  This keeps all the pthread initialization
operations at the start of a thread in one place.

Reviewed by:	corvink, markj
Differential Revision:	https://reviews.freebsd.org/D37646
This commit is contained in:
John Baldwin 2022-12-21 10:33:18 -08:00
parent 8487443792
commit 7224a96a55
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
usr.sbin/bhyve/bhyverun.c
View File

@ -525,7 +525,7 @@ fbsdrun_start_thread(void *param)
{
char tname[MAXCOMLEN + 1];
struct mt_vmm_info *mtp;
int vcpu;
int error, vcpu;
mtp = param;
vcpu = mtp->mt_vcpu;
@ -533,6 +533,12 @@ fbsdrun_start_thread(void *param)
snprintf(tname, sizeof(tname), "vcpu %d", vcpu);
pthread_set_name_np(mtp->mt_thr, tname);
if (vcpumap[vcpu] != NULL) {
error = pthread_setaffinity_np(mtp->mt_thr, sizeof(cpuset_t),
vcpumap[vcpu]);
assert(error == 0);
}
#ifdef BHYVE_SNAPSHOT
checkpoint_cpu_add(vcpu);
#endif
@ -971,12 +977,6 @@ vm_loop(struct vmctx *ctx, int vcpu)
enum vm_exitcode exitcode;
cpuset_t active_cpus;
if (vcpumap[vcpu] != NULL) {
error = pthread_setaffinity_np(pthread_self(),
sizeof(cpuset_t), vcpumap[vcpu]);
assert(error == 0);
}
error = vm_active_cpus(ctx, &active_cpus);
assert(CPU_ISSET(vcpu, &active_cpus));