d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid double-free. In error cases ipfw(4) frees the mbuf(4), we don't

Browse Source 
need to.

PR:		kern/145462
This commit is contained in:
Gleb Smirnoff 2010-07-06 10:45:38 +00:00
parent 6e19f4de12
commit 7418c6e1a9
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/netgraph/ng_ipfw.c
View File

@ -265,11 +265,8 @@ ng_ipfw_input(struct mbuf **m0, int dir, struct ip_fw_args *fwa, int tee)
* Node must be loaded and corresponding hook must be present.
*/
if (fw_node == NULL ||
(hook = ng_ipfw_findhook1(fw_node, fwa->rule.info)) == NULL) {
if (tee == 0)
m_freem(*m0);
(hook = ng_ipfw_findhook1(fw_node, fwa->rule.info)) == NULL)
return (ESRCH); /* no hook associated with this rule */
}
/*
* We have two modes: in normal mode we add a tag to packet, which is