From 74cc33ce5785a85d68d6e3ef0ec9ba3a3678c6e5 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Wed, 15 Aug 2018 00:15:40 +0000 Subject: [PATCH] Flesh out a comment about what we're doing with read bias and trims. Sponsored by: Netflix --- sys/cam/cam_iosched.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/cam/cam_iosched.c b/sys/cam/cam_iosched.c index 769367f4164b..6e1f6d52d0eb 100644 --- a/sys/cam/cam_iosched.c +++ b/sys/cam/cam_iosched.c @@ -1311,7 +1311,9 @@ cam_iosched_get_trim(struct cam_iosched_softc *isc) if (do_dynamic_iosched) { /* * If pending read, prefer that based on current read bias - * setting. + * setting. The read bias is shared for both writes and + * TRIMs, but on TRIMs the bias is for a combined TRIM + * not a single TRIM request that's come in. */ if (bioq_first(&isc->bio_queue) && isc->current_read_bias) { isc->current_read_bias--;