d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make all three if conditions look similar by always initializing nsec

Browse Source 
and moving the default initialization of prec into the else clause.
The clang static analyzer erroneously thought that nsec can be used
uninitialized here; it was not actually possible, but better to make
the code clearer.  (Clang can't know that sprintf() won't modify *pi
behind the scenes.)
This commit is contained in:
Garrett Wollman 2009-11-25 04:35:54 +00:00
parent ab5b2fafec
commit 750a395ba6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/libc/stdio/xprintf_time.c
View File

@ -64,7 +64,6 @@ __printf_render_time(struct __printf_io *io, const struct printf_info *pi, const
intmax_t t, tx;
int i, prec, nsec;
prec = 0;
if (pi->is_long) {
tv = *((struct timeval **)arg[0]);
t = tv->tv_sec;
@ -78,6 +77,8 @@ __printf_render_time(struct __printf_io *io, const struct printf_info *pi, const
} else {
tp = *((time_t **)arg[0]);
t = *tp;
nsec = 0;
prec = 0;
}
p = buf;