d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

When starting up threads in taskqueue_start_threads create them

Browse Source 
stopped before adjusting their priority and setting them on the run
q so they cannot race for resources (pointed out by njl).

While here add a console printf on thread create fails; otherwise
noone may notice (e.g. return value is always 0 and caller has no
way to verify).

Reviewed by:	jhb, scottl
MFC after:	2 weeks
This commit is contained in:
Sam Leffler 2006-05-24 22:11:07 +00:00
parent 33c6a485bd
commit 75b773ae3d
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
sys/kern/subr_taskqueue.c
View File

@ -315,6 +315,7 @@ taskqueue_start_threads(struct taskqueue **tqp, int count, int pri,
{ {
va_list ap; va_list ap;
struct taskqueue *tq; struct taskqueue *tq;
struct thread *td;
char ktname[MAXCOMLEN]; char ktname[MAXCOMLEN];
int i, error; int i, error;
@ -336,21 +337,27 @@ taskqueue_start_threads(struct taskqueue **tqp, int count, int pri,
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
if (count == 1) if (count == 1)
error = kthread_create(taskqueue_thread_loop, tqp, error = kthread_create(taskqueue_thread_loop, tqp,
&tq->tq_pproc[i], 0, 0, ktname); &tq->tq_pproc[i], RFSTOPPED, 0, ktname);
else else
error = kthread_create(taskqueue_thread_loop, tqp, error = kthread_create(taskqueue_thread_loop, tqp,
&tq->tq_pproc[i], 0, 0, "%s_%d", ktname, i); &tq->tq_pproc[i], RFSTOPPED, 0, "%s_%d", ktname, i);
if (error == 0) { if (error) {
mtx_lock_spin(&sched_lock);
sched_prio(FIRST_THREAD_IN_PROC(tq->tq_pproc[i]), pri);
mtx_unlock_spin(&sched_lock);
tq->tq_pcount++;
} else {
/* should be ok to continue, taskqueue_free will dtrt */ /* should be ok to continue, taskqueue_free will dtrt */
printf("%s: kthread_create(%s): error %d", printf("%s: kthread_create(%s): error %d",
__func__, ktname, error); __func__, ktname, error);
tq->tq_pproc[i] = NULL; /* paranoid */
} else
tq->tq_pcount++;
} }
mtx_lock_spin(&sched_lock);
for (i = 0; i < count; i++) {
if (tq->tq_pproc[i] == NULL)
continue;
td = FIRST_THREAD_IN_PROC(tq->tq_pproc[i]);
sched_prio(td, pri);
setrunqueue(td, SRQ_BORING);
} }
mtx_unlock_spin(&sched_lock);
return (0); return (0);
} }