From 75cabb639a071d6427b344b5c45a6536c180d3ec Mon Sep 17 00:00:00 2001
From: Jeff Roberson <jeff@FreeBSD.org>
Date: Wed, 25 Sep 2002 02:28:07 +0000
Subject: [PATCH]  - Hold the vp lock while accessing v_vflags.

---
 sys/fs/nullfs/null_vfsops.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/sys/fs/nullfs/null_vfsops.c b/sys/fs/nullfs/null_vfsops.c
index ec41e3008a8e..d6ca21115f6d 100644
--- a/sys/fs/nullfs/null_vfsops.c
+++ b/sys/fs/nullfs/null_vfsops.c
@@ -170,14 +170,11 @@ nullfs_mount(mp, ndp, td)
 	 * a reference on the root vnode.
 	 */
 	error = null_nodeget(mp, lowerrootvp, &vp);
-	/*
-	 * Unlock the node (either the lower or the alias)
-	 */
-	VOP_UNLOCK(vp, 0, td);
 	/*
 	 * Make sure the node alias worked
 	 */
 	if (error) {
+		VOP_UNLOCK(vp, 0, td);
 		vrele(lowerrootvp);
 		free(xmp, M_NULLFSMNT);	/* XXX */
 		return (error);
@@ -187,10 +184,15 @@ nullfs_mount(mp, ndp, td)
 	 * Keep a held reference to the root vnode.
 	 * It is vrele'd in nullfs_unmount.
 	 */
-	mp_fixme("Unlocked vflag access");
 	nullm_rootvp = vp;
 	nullm_rootvp->v_vflag |= VV_ROOT;
 	xmp->nullm_rootvp = nullm_rootvp;
+
+	/*
+	 * Unlock the node (either the lower or the alias)
+	 */
+	VOP_UNLOCK(vp, 0, td);
+
 	if (NULLVPTOLOWERVP(nullm_rootvp)->v_mount->mnt_flag & MNT_LOCAL)
 		mp->mnt_flag |= MNT_LOCAL;
 	mp->mnt_data = (qaddr_t) xmp;