d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid casts as lvalues. Declare local variable as u_char * instead of

Browse Source 
declaring it as u_short * and casting it back to uchar * all over the place.
This commit is contained in:
Alexander Kabaev 2004-07-28 06:58:23 +00:00
parent a0ec13c419
commit 766f8c9247
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/netipx/ipx_cksum.c
View File

@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$");
u_short
ipx_cksum(struct mbuf *m, int len) {
u_int32_t sum = 0;
u_short *w;
u_char *w;
u_char oldtc;
int mlen, words;
struct ipx *ipx;
@ -62,7 +62,7 @@ ipx_cksum(struct mbuf *m, int len) {
ipx = mtod(m, struct ipx*);
oldtc = ipx->ipx_tc;
ipx->ipx_tc = 0;
w = &ipx->ipx_len;
w = (u_char *)&ipx->ipx_len;
len -= 2;
mlen = 2;
@ -83,7 +83,7 @@ ipx_cksum(struct mbuf *m, int len) {
break;
mlen &= 1;
if (mlen) {
buf.b[0] = *(u_char*)w;
buf.b[0] = *w;
if (--len == 0) {
buf.b[1] = 0;
sum += buf.w;
@ -93,11 +93,11 @@ ipx_cksum(struct mbuf *m, int len) {
m = m->m_next;
if (m == NULL)
break;
w = mtod(m, u_short*);
w = mtod(m, u_char *);
if (mlen) {
buf.b[1] = *(u_char*)w;
buf.b[1] = *w;
sum += buf.w;
((u_char*)w)++;
w++;
if (--len == 0)
break;
}