From 7e3a88ea3c51c3a2608d05d23c7be87d8c5c829d Mon Sep 17 00:00:00 2001 From: Robert Watson Date: Sat, 14 Aug 2004 00:15:26 +0000 Subject: [PATCH] Since if_xe doesn't contain locking or run with INTR_MPSAFE, mark the interface as IFF_NEEDSGIANT so if_start is run holding Giant. --- sys/dev/xe/if_xe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/xe/if_xe.c b/sys/dev/xe/if_xe.c index e47d8d2d03c0..c60fa0a60399 100644 --- a/sys/dev/xe/if_xe.c +++ b/sys/dev/xe/if_xe.c @@ -233,7 +233,8 @@ xe_attach (device_t dev) scp->ifp->if_softc = scp; if_initname(scp->ifp, device_get_name(dev), device_get_unit(dev)); scp->ifp->if_timer = 0; - scp->ifp->if_flags = (IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST); + scp->ifp->if_flags = (IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST | + IFF_NEEDSGIANT); scp->ifp->if_linkmib = &scp->mibdata; scp->ifp->if_linkmiblen = sizeof scp->mibdata; scp->ifp->if_start = xe_start;