d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fd: make fgetvp_rights work without the filedesc lock

Browse Source 
Reviewed by:	kib
Differential Revision:	https://reviews.freebsd.org/D23883
This commit is contained in:
Mateusz Guzik 2020-03-01 21:50:13 +00:00
parent 7f746c9fcc
commit 8243063f9b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/kern/kern_descrip.c
View File

@ -3028,13 +3028,11 @@ int
fgetvp_rights(struct thread *td, int fd, cap_rights_t *needrightsp,
struct filecaps *havecaps, struct vnode **vpp)
{
struct filedesc *fdp;
struct filecaps caps;
struct file *fp;
int error;
fdp = td->td_proc->p_fd;
error = fget_cap_locked(fdp, fd, needrightsp, &fp, &caps);
error = fget_cap(td, fd, needrightsp, &fp, &caps);
if (error != 0)
return (error);
if (fp->f_ops == &badfileops) {
@ -3049,10 +3047,12 @@ fgetvp_rights(struct thread *td, int fd, cap_rights_t *needrightsp,
*havecaps = caps;
*vpp = fp->f_vnode;
vrefact(*vpp);
fdrop(fp, td);
return (0);
out:
filecaps_free(&caps);
fdrop(fp, td);
return (error);
}