d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ipmi: Remove write only variables used to read form hardware

Browse Source 
Sponsored by:		Netflix
This commit is contained in:
Warner Losh 2022-04-05 20:00:29 -06:00
parent 1545c66789
commit 8707108f33
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/dev/ipmi/ipmi_kcs.c
View File

@ -93,11 +93,10 @@ kcs_wait_for_obf(struct ipmi_softc *sc, bool level)
static void
kcs_clear_obf(struct ipmi_softc *sc, int status)
{
int data;
/* Clear OBF */
if (status & KCS_STATUS_OBF) {
data = INB(sc, KCS_DATA);
INB(sc, KCS_DATA);
}
}
@ -266,7 +265,6 @@ static int
kcs_read_byte(struct ipmi_softc *sc, u_char *data)
{
int status;
u_char dummy;
/* Wait for IBF = 0 */
status = kcs_wait_for_ibf(sc, 0);
@ -296,7 +294,7 @@ kcs_read_byte(struct ipmi_softc *sc, u_char *data)
return (0);
/* Read Dummy */
dummy = INB(sc, KCS_DATA);
INB(sc, KCS_DATA);
return (2);
}
@ -545,7 +543,7 @@ ipmi_kcs_attach(struct ipmi_softc *sc)
int
ipmi_kcs_probe_align(struct ipmi_softc *sc)
{
int data, status;
int status;
sc->ipmi_io_spacing = 1;
retry:
@ -587,7 +585,7 @@ ipmi_kcs_probe_align(struct ipmi_softc *sc)
/* Clear OBF */
if (status & KCS_STATUS_OBF)
data = INB(sc, KCS_DATA);
INB(sc, KCS_DATA);
/* 0x00 to DATA_IN */
OUTB(sc, KCS_DATA, 0);
@ -607,7 +605,7 @@ ipmi_kcs_probe_align(struct ipmi_softc *sc)
}
/* Read error status. */
data = INB(sc, KCS_DATA);
INB(sc, KCS_DATA);
/* Write dummy READ to DATA_IN. */
OUTB(sc, KCS_DATA, KCS_DATA_IN_READ);
@ -629,7 +627,7 @@ ipmi_kcs_probe_align(struct ipmi_softc *sc)
/* Clear OBF */
if (status & KCS_STATUS_OBF)
data = INB(sc, KCS_DATA);
INB(sc, KCS_DATA);
} else
device_printf(sc->ipmi_dev, "KCS probe: end state %x\n",
KCS_STATUS_STATE(status));