d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Coding style fix: Use "foo = 1" instead of "foo++" to assign

Browse Source 
the truth value to a boolean variable, especially when inside
a loop.  The variable can overflow otherwise, at least in theory.
This commit is contained in:
Yaroslav Tykhiy 2003-06-10 15:38:35 +00:00
parent 018319c226
commit 8b52276d10
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libexec/getty/main.c
View File

@ -356,7 +356,7 @@ main(int argc, char *argv[])
else if (islower(*p)) else if (islower(*p))
lower = 1; lower = 1;
else if (isdigit(*p)) else if (isdigit(*p))
digit++; digit = 1;
*q++ = *p++; *q++ = *p++;
} }
} else if (!(PL && PP)) } else if (!(PL && PP))
@ -604,7 +604,7 @@ getname(void)
np = name; np = name;
continue; continue;
} else if (isdigit(c)) } else if (isdigit(c))
digit++; digit = 1;
if (IG && (c <= ' ' || c > 0176)) if (IG && (c <= ' ' || c > 0176))
continue; continue;
*np++ = c; *np++ = c;