d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use strlcpy when copying com to pdu->community to avoid potential

Browse Source 
buffer overruns

MFC after:	1 week
Reported by:	Coverity
CID:		1006823, 1006824
This commit is contained in:
Enji Cooper 2016-12-31 12:18:17 +00:00
parent c4114bd1f5
commit 8e02b381d3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/bsnmp/snmpd/trap.c
View File

@ -422,7 +422,7 @@ snmp_create_v1_trap(struct snmp_pdu *pdu, char *com,
const struct asn_oid *trap_oid)
{
memset(pdu, 0, sizeof(*pdu));
strcpy(pdu->community, com);
strlcpy(pdu->community, com, sizeof(pdu->community));
pdu->version = SNMP_V1;
pdu->type = SNMP_PDU_TRAP;
@ -439,7 +439,7 @@ snmp_create_v2_trap(struct snmp_pdu *pdu, char *com,
const struct asn_oid *trap_oid)
{
memset(pdu, 0, sizeof(*pdu));
strcpy(pdu->community, com);
strlcpy(pdu->community, com, sizeof(pdu->community));
pdu->version = SNMP_V2c;
pdu->type = SNMP_PDU_TRAP2;