From 8f226f4c23e6fd158ad8f3c26be8d185cc0b73a2 Mon Sep 17 00:00:00 2001 From: Mateusz Guzik Date: Wed, 19 Aug 2020 07:28:01 +0000 Subject: [PATCH] vfs: remove the always-curthread td argument from VOP_RECLAIM --- sys/fs/cd9660/cd9660_node.c | 1 - sys/fs/fuse/fuse_vnops.c | 3 +-- sys/fs/nfsclient/nfs_clnode.c | 7 +++++-- sys/fs/smbfs/smbfs_node.c | 1 - sys/fs/unionfs/union_vnops.c | 2 +- sys/kern/uipc_mqueue.c | 1 - sys/kern/vfs_subr.c | 2 +- sys/kern/vnode_if.src | 1 - sys/ufs/ufs/ufs_inode.c | 1 - 9 files changed, 8 insertions(+), 11 deletions(-) diff --git a/sys/fs/cd9660/cd9660_node.c b/sys/fs/cd9660/cd9660_node.c index c74bf4a3005c..a18216994e20 100644 --- a/sys/fs/cd9660/cd9660_node.c +++ b/sys/fs/cd9660/cd9660_node.c @@ -86,7 +86,6 @@ int cd9660_reclaim(ap) struct vop_reclaim_args /* { struct vnode *a_vp; - struct thread *a_td; } */ *ap; { struct vnode *vp = ap->a_vp; diff --git a/sys/fs/fuse/fuse_vnops.c b/sys/fs/fuse/fuse_vnops.c index a45f1b962c9b..32e47ccf6c45 100644 --- a/sys/fs/fuse/fuse_vnops.c +++ b/sys/fs/fuse/fuse_vnops.c @@ -1527,14 +1527,13 @@ fuse_vnop_readlink(struct vop_readlink_args *ap) /* struct vnop_reclaim_args { struct vnode *a_vp; - struct thread *a_td; }; */ static int fuse_vnop_reclaim(struct vop_reclaim_args *ap) { struct vnode *vp = ap->a_vp; - struct thread *td = ap->a_td; + struct thread *td = curthread; struct fuse_vnode_data *fvdat = VTOFUD(vp); struct fuse_filehandle *fufh, *fufh_tmp; diff --git a/sys/fs/nfsclient/nfs_clnode.c b/sys/fs/nfsclient/nfs_clnode.c index e4592fdbf861..237ff30a7209 100644 --- a/sys/fs/nfsclient/nfs_clnode.c +++ b/sys/fs/nfsclient/nfs_clnode.c @@ -286,6 +286,9 @@ ncl_reclaim(struct vop_reclaim_args *ap) struct vnode *vp = ap->a_vp; struct nfsnode *np = VTONFS(vp); struct nfsdmap *dp, *dp2; + struct thread *td; + + td = curthread; /* * If the NLM is running, give it a chance to abort pending @@ -295,7 +298,7 @@ ncl_reclaim(struct vop_reclaim_args *ap) nfs_reclaim_p(ap); NFSLOCKNODE(np); - ncl_releasesillyrename(vp, ap->a_td); + ncl_releasesillyrename(vp, td); NFSUNLOCKNODE(np); if (NFS_ISV4(vp) && vp->v_type == VREG) @@ -305,7 +308,7 @@ ncl_reclaim(struct vop_reclaim_args *ap) * ncl_inactive(), but there are cases where it is not * called, so we need to do it again here. */ - (void) nfsrpc_close(vp, 1, ap->a_td); + (void) nfsrpc_close(vp, 1, td); vfs_hash_remove(vp); diff --git a/sys/fs/smbfs/smbfs_node.c b/sys/fs/smbfs/smbfs_node.c index f544d1019e83..9fac9c504f03 100644 --- a/sys/fs/smbfs/smbfs_node.c +++ b/sys/fs/smbfs/smbfs_node.c @@ -260,7 +260,6 @@ int smbfs_reclaim(ap) struct vop_reclaim_args /* { struct vnode *a_vp; - struct thread *a_p; } */ *ap; { struct vnode *vp = ap->a_vp; diff --git a/sys/fs/unionfs/union_vnops.c b/sys/fs/unionfs/union_vnops.c index 1ca75543f069..09fbccb3d7ff 100644 --- a/sys/fs/unionfs/union_vnops.c +++ b/sys/fs/unionfs/union_vnops.c @@ -1731,7 +1731,7 @@ unionfs_reclaim(struct vop_reclaim_args *ap) { /* UNIONFS_INTERNAL_DEBUG("unionfs_reclaim: enter\n"); */ - unionfs_noderem(ap->a_vp, ap->a_td); + unionfs_noderem(ap->a_vp, curthread); /* UNIONFS_INTERNAL_DEBUG("unionfs_reclaim: leave\n"); */ diff --git a/sys/kern/uipc_mqueue.c b/sys/kern/uipc_mqueue.c index 28fc1d84329b..29452882d86b 100644 --- a/sys/kern/uipc_mqueue.c +++ b/sys/kern/uipc_mqueue.c @@ -1099,7 +1099,6 @@ mqfs_inactive(struct vop_inactive_args *ap) struct vop_reclaim_args { struct vop_generic_args a_gen; struct vnode *a_vp; - struct thread *a_td; }; #endif diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 388e576fcde4..c1e0656095e7 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -3879,7 +3879,7 @@ vgonel(struct vnode *vp) /* * Reclaim the vnode. */ - if (VOP_RECLAIM(vp, td)) + if (VOP_RECLAIM(vp)) panic("vgone: cannot reclaim"); if (mp != NULL) vn_finished_secondary_write(mp); diff --git a/sys/kern/vnode_if.src b/sys/kern/vnode_if.src index 07e20e6f81c7..fde75d91325c 100644 --- a/sys/kern/vnode_if.src +++ b/sys/kern/vnode_if.src @@ -401,7 +401,6 @@ vop_need_inactive { vop_reclaim { IN struct vnode *vp; - IN struct thread *td; }; diff --git a/sys/ufs/ufs/ufs_inode.c b/sys/ufs/ufs/ufs_inode.c index 25827c427241..9503d7f30829 100644 --- a/sys/ufs/ufs/ufs_inode.c +++ b/sys/ufs/ufs/ufs_inode.c @@ -222,7 +222,6 @@ int ufs_reclaim(ap) struct vop_reclaim_args /* { struct vnode *a_vp; - struct thread *a_td; } */ *ap; { struct vnode *vp = ap->a_vp;