d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Actually, check for any kind of "C string type".

Browse Source 
Approved by:    rpaulo (mentor)
This commit is contained in:
Roman Divacky 2010-10-13 17:01:33 +00:00
parent 565424b2fd
commit 9221387423
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
contrib/llvm/tools/clang/lib/Sema/SemaChecking.cpp
View File

@ -1519,14 +1519,10 @@ CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
// Now type check the data expression that matches the
// format specifier.
const Expr *Ex = getDataArg(argIndex);
QualType Pointee = S.Context.UnsignedCharTy;
Pointee.addConst();
QualType constType = (CS.getKind() == ConversionSpecifier::bArg) ? S.Context.IntTy : S.Context.getPointerType(Pointee);
QualType type = (CS.getKind() == ConversionSpecifier::bArg) ? S.Context.IntTy : S.Context.getPointerType(S.Context.UnsignedCharTy);
const analyze_printf::ArgTypeResult &ConstATR = constType;
const analyze_printf::ArgTypeResult &ATR = type;
if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType()) &&
!ConstATR.matchesType(S.Context, Ex->getType()))
const analyze_printf::ArgTypeResult &ATR =
(CS.getKind() == ConversionSpecifier::bArg) ?
ArgTypeResult(S.Context.IntTy) : ArgTypeResult::CStrTy;
if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType()))
S.Diag(getLocationOfByte(CS.getStart()),
diag::warn_printf_conversion_argument_type_mismatch)
<< ATR.getRepresentativeType(S.Context) << Ex->getType()