d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use a temporary buffer in sys_setgroups for requests with <= XU_NGROUPS groups.

Browse Source 
Submitted by:	Tiwei Bie <btw mail.ustc.edu.cn>
X-Additional: JuniorJobs project
MFC after:	2 weeks
This commit is contained in:
Mateusz Guzik 2014-10-26 05:39:42 +00:00
parent 160ef77abf
commit 92b064f43d
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
sys/kern/kern_prot.c
View File

@ -806,17 +806,24 @@ int
sys_setgroups(struct thread *td, struct setgroups_args *uap)
{
gid_t *groups = NULL;
gid_t smallgroups[XU_NGROUPS];
u_int gidsetsize;
int error;
if (uap->gidsetsize > ngroups_max + 1)
gidsetsize = uap->gidsetsize;
if (gidsetsize > ngroups_max + 1)
return (EINVAL);
groups = malloc(uap->gidsetsize * sizeof(gid_t), M_TEMP, M_WAITOK);
error = copyin(uap->gidset, groups, uap->gidsetsize * sizeof(gid_t));
if (gidsetsize > XU_NGROUPS)
groups = malloc(gidsetsize * sizeof(gid_t), M_TEMP, M_WAITOK);
else
groups = smallgroups;
error = copyin(uap->gidset, groups, gidsetsize * sizeof(gid_t));
if (error)
goto out;
error = kern_setgroups(td, uap->gidsetsize, groups);
error = kern_setgroups(td, gidsetsize, groups);
out:
free(groups, M_TEMP);
if (gidsetsize > XU_NGROUPS)
free(groups, M_TEMP);
return (error);
}