d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate XXX comments regarding allocation failures when retrieving

Browse Source 
the peer address by using M_WAITOK in ipx_setpeeraddr() to prevent
allocation failure.  The socket reference used to reach these calls
will prevent the ipxpcb from being released prematurely.
This commit is contained in:
Robert Watson 2005-01-02 15:25:59 +00:00
parent 360fb9f83a
commit 944731d517
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/netipx/ipx_pcb.c
View File

@ -301,13 +301,13 @@ ipx_setpeeraddr(ipxp, nam)
struct sockaddr **nam;
{
struct sockaddr_ipx *sipx, ssipx;
sipx = &ssipx;
bzero((caddr_t)sipx, sizeof(*sipx));
bzero(sipx, sizeof(*sipx));
sipx->sipx_len = sizeof(*sipx);
sipx->sipx_family = AF_IPX;
sipx->sipx_addr = ipxp->ipxp_faddr;
*nam = sodupsockaddr((struct sockaddr *)sipx, M_NOWAIT);
*nam = sodupsockaddr((struct sockaddr *)sipx, M_WAITOK);
}
struct ipxpcb *

4
sys/netipx/ipx_usrreq.c
View File

@ -531,7 +531,7 @@ ipx_peeraddr(so, nam)
{
struct ipxpcb *ipxp = sotoipxpcb(so);
ipx_setpeeraddr(ipxp, nam); /* XXX what if alloc fails? */
ipx_setpeeraddr(ipxp, nam);
return (0);
}
@ -599,7 +599,7 @@ ipx_sockaddr(so, nam)
{
struct ipxpcb *ipxp = sotoipxpcb(so);
ipx_setsockaddr(ipxp, nam); /* XXX what if alloc fails? */
ipx_setsockaddr(ipxp, nam);
return (0);
}