d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary CURVNET_SET() calls where curvnet context is

Browse Source 
(i.e. seems to be) already set.

This should reduce console noise due to curvnet recursion reports.

This change has no impact on nooptions VIMAGE builds.
Approved by:	julian (mentor)
This commit is contained in:
Marko Zec 2009-05-06 13:30:46 +00:00
parent 743da3bcdb
commit 94e9f5a1c2
2 changed files with 1 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
sys/netinet/igmp.c
View File

@ -528,9 +528,6 @@ igmp_ra_alloc(void)
/*
* Attach IGMP when PF_INET is attached to an interface.
*
* VIMAGE: Currently we set the vnet pointer, although it is
* likely that it was already set by our caller.
*/
struct igmp_ifinfo *
igmp_domifattach(struct ifnet *ifp)
@ -540,7 +537,6 @@ igmp_domifattach(struct ifnet *ifp)
CTR3(KTR_IGMPV3, "%s: called for ifp %p(%s)",
__func__, ifp, ifp->if_xname);
CURVNET_SET(ifp->if_vnet);
IGMP_LOCK();
igi = igi_alloc_locked(ifp);
@ -548,7 +544,6 @@ igmp_domifattach(struct ifnet *ifp)
igi->igi_flags |= IGIF_SILENT;
IGMP_UNLOCK();
CURVNET_RESTORE();
return (igi);
}
@ -600,9 +595,6 @@ igi_alloc_locked(/*const*/ struct ifnet *ifp)
*
* SMPNG: igmp_ifdetach() needs to take IF_ADDR_LOCK().
* XXX This is also bitten by unlocked ifma_protospec access.
*
* VIMAGE: curvnet should have been set by caller, but let's not assume
* that for now.
*/
void
igmp_ifdetach(struct ifnet *ifp)
@ -614,8 +606,6 @@ igmp_ifdetach(struct ifnet *ifp)
CTR3(KTR_IGMPV3, "%s: called for ifp %p(%s)", __func__, ifp,
ifp->if_xname);
CURVNET_SET(ifp->if_vnet);
IGMP_LOCK();
igi = ((struct in_ifinfo *)ifp->if_afdata[AF_INET])->ii_igmp;
@ -648,15 +638,10 @@ igmp_ifdetach(struct ifnet *ifp)
}
IGMP_UNLOCK();
CURVNET_RESTORE();
}
/*
* Hook for domifdetach.
*
* VIMAGE: curvnet should have been set by caller, but let's not assume
* that for now.
*/
void
igmp_domifdetach(struct ifnet *ifp)
@ -666,14 +651,12 @@ igmp_domifdetach(struct ifnet *ifp)
CTR3(KTR_IGMPV3, "%s: called for ifp %p(%s)",
__func__, ifp, ifp->if_xname);
CURVNET_SET(ifp->if_vnet);
IGMP_LOCK();
igi = ((struct in_ifinfo *)ifp->if_afdata[AF_INET])->ii_igmp;
igi_delete_locked(ifp);
IGMP_UNLOCK();
CURVNET_RESTORE();
}
static void

20
sys/netinet6/mld6.c
View File

@ -292,11 +292,9 @@ static __inline uint32_t
mld_restore_context(struct mbuf *m)
{
#ifdef notyet
#if defined(VIMAGE) && defined(INVARIANTS)
KASSERT(curvnet == (m->m_pkthdr.header),
KASSERT(curvnet == m->m_pkthdr.header,
("%s: called when curvnet was not restored", __func__));
#endif
#endif
return (m->m_pkthdr.flowid);
}
@ -455,8 +453,6 @@ mld_is_addr_reported(const struct in6_addr *addr)
* Attach MLD when PF_INET6 is attached to an interface.
*
* SMPng: Normally called with IF_AFDATA_LOCK held.
* VIMAGE: Currently we set the vnet pointer, although it is
* likely that it was already set by our caller.
*/
struct mld_ifinfo *
mld_domifattach(struct ifnet *ifp)
@ -466,7 +462,6 @@ mld_domifattach(struct ifnet *ifp)
CTR3(KTR_MLD, "%s: called for ifp %p(%s)",
__func__, ifp, ifp->if_xname);
CURVNET_SET(ifp->if_vnet);
MLD_LOCK();
mli = mli_alloc_locked(ifp);
@ -474,7 +469,6 @@ mld_domifattach(struct ifnet *ifp)
mli->mli_flags |= MLIF_SILENT;
MLD_UNLOCK();
CURVNET_RESTORE();
return (mli);
}
@ -528,9 +522,6 @@ mli_alloc_locked(/*const*/ struct ifnet *ifp)
* SMPng: Caller must hold IN6_MULTI_LOCK().
* Must take IF_ADDR_LOCK() to cover if_multiaddrs iterator.
* XXX This routine is also bitten by unlocked ifma_protospec access.
*
* VIMAGE: curvnet should have been set by caller, but let's not assume
* that for now.
*/
void
mld_ifdetach(struct ifnet *ifp)
@ -542,8 +533,6 @@ mld_ifdetach(struct ifnet *ifp)
CTR3(KTR_MLD, "%s: called for ifp %p(%s)", __func__, ifp,
ifp->if_xname);
CURVNET_SET(ifp->if_vnet);
IN6_MULTI_LOCK_ASSERT();
MLD_LOCK();
@ -570,7 +559,6 @@ mld_ifdetach(struct ifnet *ifp)
}
MLD_UNLOCK();
CURVNET_RESTORE();
}
/*
@ -578,8 +566,6 @@ mld_ifdetach(struct ifnet *ifp)
* Runs after link-layer cleanup; free MLD state.
*
* SMPng: Normally called with IF_AFDATA_LOCK held.
* VIMAGE: curvnet should have been set by caller, but let's not assume
* that for now.
*/
void
mld_domifdetach(struct ifnet *ifp)
@ -588,13 +574,9 @@ mld_domifdetach(struct ifnet *ifp)
CTR3(KTR_MLD, "%s: called for ifp %p(%s)",
__func__, ifp, ifp->if_xname);
CURVNET_SET(ifp->if_vnet);
MLD_LOCK();
mli_delete_locked(ifp);
MLD_UNLOCK();
CURVNET_RESTORE();
}
static void