d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

amdsbwd: add suspend and resume methods

Browse Source 
Without the suspend method the watchdog may fire in S1 state.  Without
the resume method the watchdog is not re-enabled after returning from S3
state.  I observe this on one of my systems.

Not sure if watchdog(4) should participate in the suspend actions.
Right now everything is up to individual drivers.

MFC after:	2 weeks
This commit is contained in:
Andriy Gapon 2018-05-03 15:33:18 +00:00
parent 68ff29affa
commit 9a042dbc6e
1 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
sys/dev/amdsbwd/amdsbwd.c
View File

@ -104,12 +104,16 @@ static void amdsbwd_identify(driver_t *driver, device_t parent);
static int amdsbwd_probe(device_t dev);
static int amdsbwd_attach(device_t dev);
static int amdsbwd_detach(device_t dev);
static int amdsbwd_suspend(device_t dev);
static int amdsbwd_resume(device_t dev);
static device_method_t amdsbwd_methods[] = {
DEVMETHOD(device_identify, amdsbwd_identify),
DEVMETHOD(device_probe, amdsbwd_probe),
DEVMETHOD(device_attach, amdsbwd_attach),
DEVMETHOD(device_detach, amdsbwd_detach),
DEVMETHOD(device_suspend, amdsbwd_suspend),
DEVMETHOD(device_resume, amdsbwd_resume),
#if 0
DEVMETHOD(device_shutdown, amdsbwd_detach),
#endif
@ -553,3 +557,30 @@ amdsbwd_detach(device_t dev)
return (0);
}
static int
amdsbwd_suspend(device_t dev)
{
struct amdsbwd_softc *sc;
uint32_t val;
sc = device_get_softc(dev);
val = wdctrl_read(sc);
val &= ~AMDSB_WD_RUN;
wdctrl_write(sc, val);
return (0);
}
static int
amdsbwd_resume(device_t dev)
{
struct amdsbwd_softc *sc;
sc = device_get_softc(dev);
wdctrl_write(sc, AMDSB_WD_FIRED);
if (sc->active) {
amdsbwd_tmr_set(sc, sc->timeout);
amdsbwd_tmr_enable(sc);
amdsbwd_tmr_reload(sc);
}
return (0);
}