d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Coverity CID 1016714 Resource leak in process_file_actions_entry()

Browse Source 
Don't leak a file descriptor of _dup2() fails (shouldn't happen).

Reported by:	Coverity
CID:		1016714
MFC after:	1 week
This commit is contained in:
Don Lewis 2016-05-25 07:13:53 +00:00
parent 015f4df218
commit 9b842193f9
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/libc/gen/posix_spawn.c
View File

@ -140,7 +140,7 @@ process_spawnattr(const posix_spawnattr_t sa)
static int
process_file_actions_entry(posix_spawn_file_actions_entry_t *fae)
{
int fd;
int fd, saved_errno;
switch (fae->fae_action) {
case FAE_OPEN:
@ -149,8 +149,11 @@ process_file_actions_entry(posix_spawn_file_actions_entry_t *fae)
if (fd < 0)
return (errno);
if (fd != fae->fae_fildes) {
if (_dup2(fd, fae->fae_fildes) == -1)
return (errno);
if (_dup2(fd, fae->fae_fildes) == -1) {
saved_errno = errno;
(void)_close(fd);
return (saved_errno);
}
if (_close(fd) != 0) {
if (errno == EBADF)
return (EBADF);