d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

As statfs.f_flags are uint64_t the local variables should be as well.

Browse Source 
We'll start noticing this with the next flag introduced as the lower
32bit are all used.
As this is old code we might need to do a full tree sweep one day, unless
changing our strategy to use a different `API' for getting/setting flags
along with the rest of the statfs data.

While here compare to 0 explicitly [1].

Suggested by:	kib [1]
Reviewed by:	kib
MFC after:	5 days
This commit is contained in:
Bjoern A. Zeeb 2010-03-07 16:45:18 +00:00
parent 376aadf896
commit 9df3a16421
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sbin/mount/mount.c
View File

@ -91,7 +91,7 @@ char *flags2opts(int);
/* Map from mount options to printable formats. */
static struct opt {
int o_opt;
uint64_t o_opt;
const char *o_name;
} optnames[] = {
{ MNT_ASYNC, "asynchronous" },
@ -612,7 +612,7 @@ mountfs(const char *vfstype, const char *spec, const char *name, int flags,
void
prmount(struct statfs *sfp)
{
int flags;
uint64_t flags;
unsigned int i;
struct opt *o;
struct passwd *pw;
@ -621,7 +621,7 @@ prmount(struct statfs *sfp)
sfp->f_fstypename);
flags = sfp->f_flags & MNT_VISFLAGMASK;
for (o = optnames; flags && o->o_opt; o++)
for (o = optnames; flags != 0 && o->o_opt != 0; o++)
if (flags & o->o_opt) {
(void)printf(", %s", o->o_name);
flags &= ~o->o_opt;