d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pf: getstates: avoid taking the hashrow lock if the row is empty

Browse Source 
Reviewed by:	mjg
MFC after:	1 week
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D30946
This commit is contained in:
Kristof Provost 2021-06-29 11:34:49 +02:00
parent 34285eefdd
commit a19ff8ce9b
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/netpfil/pf/pf_ioctl.c
View File

@ -5054,6 +5054,10 @@ pf_getstates(struct pfioc_nv *nv)
for (int i = 0; i < pf_hashmask; i++) { for (int i = 0; i < pf_hashmask; i++) {
struct pf_idhash *ih = &V_pf_idhash[i]; struct pf_idhash *ih = &V_pf_idhash[i];
/* Avoid taking the lock if there are no states in the row. */
if (LIST_EMPTY(&ih->states))
continue;
PF_HASHROW_LOCK(ih); PF_HASHROW_LOCK(ih);
LIST_FOREACH(s, &ih->states, entry) { LIST_FOREACH(s, &ih->states, entry) {
if (s->timeout == PFTM_UNLINKED) if (s->timeout == PFTM_UNLINKED)