d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

udp: Fix soroverflow SOCKBUF unlocking

Browse Source 
We hold the SOCKBUF_LOCK so use soroverflow_locked here.
This bug may manifest as a non-killable process stuck in [*so_rcv].

Approved by:	scottl
Reviewed by:	Roy Marples <roy@marples.name>
Fixes:	7045b1603bdf
MFC after:  10 days
Differential Revision:	https://reviews.freebsd.org/D31374
This commit is contained in:
Konstantin Kukushkin 2021-08-01 07:41:38 -07:00 committed by Kevin Bowling
parent 1a55a3a729
commit a61c24ddb7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/netinet/udp_usrreq.c
View File

@ -379,7 +379,7 @@ udp_append(struct inpcb *inp, struct ip *ip, struct mbuf *n, int off,
so = inp->inp_socket;
SOCKBUF_LOCK(&so->so_rcv);
if (sbappendaddr_locked(&so->so_rcv, append_sa, n, opts) == 0) {
soroverflow(so);
soroverflow_locked(so);
m_freem(n);
if (opts)
m_freem(opts);