d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Free the TX/RX list buffers /before/ tearing down net80211 state.

Browse Source 
Otherwise buffers in the RX queue get freed with their parent vap
being gone and you end up with a juicy kernel panic.
This commit is contained in:
Adrian Chadd 2015-09-26 22:20:30 +00:00
parent e19a95e53b
commit ac9e537ce0
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sys/dev/usb/wlan/if_rsu.c
View File

@ -545,18 +545,25 @@ rsu_detach(device_t self)
RSU_LOCK(sc);
rsu_stop(sc);
RSU_UNLOCK(sc);
usbd_transfer_unsetup(sc->sc_xfer, RSU_N_TRANSFER);
/*
* Free buffers /before/ we detach from net80211, else node
* references to destroyed vaps will lead to a panic.
*/
/* Free Tx/Rx buffers. */
RSU_LOCK(sc);
rsu_free_tx_list(sc);
rsu_free_rx_list(sc);
RSU_UNLOCK(sc);
/* Frames are freed; detach from net80211 */
ieee80211_ifdetach(ic);
taskqueue_drain_timeout(taskqueue_thread, &sc->calib_task);
taskqueue_drain(taskqueue_thread, &sc->tx_task);
/* Free Tx/Rx buffers. */
rsu_free_tx_list(sc);
rsu_free_rx_list(sc);
mtx_destroy(&sc->sc_mtx);
return (0);